Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix get RPO sample #1207

Merged
merged 3 commits into from
Jan 4, 2024
Merged

chore: fix get RPO sample #1207

merged 3 commits into from
Jan 4, 2024

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Jan 3, 2024 •
edited
Loading

There was an extra line here that doesn't make sense. Fixing based on external user feedback.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/318488404 🦕

@tritone
chore: fix get RPO sample
ca60471 
There was an extra line here that doesn't make sense. Fixing based
on external user feedback.
@tritone tritone requested review from a team as code owners January 3, 2024 21:28
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Jan 3, 2024
cojenco
cojenco reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tritone for the fix! We'll also need to update to calling get_bucket() to actually make a metadata GET.

samples/snippets/storage_get_rpo.py Outdated Show resolved Hide resolved
@tritone @cojenco
Update samples/snippets/storage_get_rpo.py
27bc55a 
Co-authored-by: cojenco <cathyo@google.com>
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 3, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 3, 2024
cojenco
cojenco approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-running kokoro as the auth library fix just released, thank you!

@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 4, 2024
@cojenco cojenco merged commit 243c5de into googleapis:main Jan 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

@vchudnov-g vchudnov-g Awaiting requested review from vchudnov-g vchudnov-g is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tritone @cojenco @yoshi-kokoro