feature: allow bots to have hyphens in google cloud functions

[sofisl]

Related to Issue #177: after doing some digging with @bcoe, we found out that you can publish a Google Cloud function with a hyphen. I'm recommending we make the change in this PR to provide naming consistency in the bots we create and deploy to GCF. In generate-bot, I've changed the logic so that module.exports can export a function with a hyphen, like so:

import` { GCFBootstrapper } from 'gcf-utils';
import appFn from './{{programName}}';

const bootstrap = new GCFBootstrapper();
module.exports['{{program-name}}']= bootstrap.gcf(appFn);

`

which should work.

[orthros]

Thanks for doing this!

Just for my own clarification: this change (which removes the replacement of '-' with '_' in folder names) will make it so that future bots will be able to export their functions in the manner you provided above?

As far as I can tell, this would break other bots like conventional-commit-lint as there is now a discrepancy between the folder name and the exported function name, correct?

[orthros]

Without functionname set, this will cause the gcloud functions deploy "$functionname"... to fail a few lines down, perhaps replace with functionname=${f}?

[orthros]

As in my comment, thank you for working on making this a much easier to use repo!

As far as I can tell, this would break other bots like conventional-commit-lint as there is now a discrepancy between the folder name (and therefore the function's name) and the exported function name, correct?

[bcoe]

@sofisl @orthros it sounds like we'd want to move these legacy functions to a folder that uses _ before we land this? or perhaps change the remote folders and key names accordingly?

[orthros]

@bcoe Either that or we move everything at once (fixing the function names in the process)

The problem with that is it would change the URL that the bots can be found at, and would then necessitate someone to fix the GitHub Application to point to the correct URL

[bcoe]

@sofisl I think we're going to need to figure out a migration strategy for the culprit bots before we land this, or we're going to break quite a few things.

[bcoe]

looking at the amount of work it would take to migrate all of our existing bots, and the benefit we'd get, I think we might do better @sofisl to move the logic for replacing - with _ into generate-bot, rather than removing it from @orthros' scripts (at least for the time being)...

[bcoe]

closing with tracking issue: #242