feat(buildcop): add support for Python #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python has a slightly different flavor of xUnit output. So, I updated the parsing to match (testsuites and package name handling). I switched the XML parsing to be compact. It makes iterating over the results a bit cleaner to not have to worry about 'elements'. There is no loss of accuracy for this purpose. The not-compact version only seems needed if you need stable parsing and re-printing. The Python test results also come in many different log files. So, I changed the logic for checking when a test passed to be an explicit pass rather than just not-fail. A possible downside of this is that if a failing test is renamed, the corresponding issue will not be automatically closed/renamed.
googlebot
added
the
cla: yes
bcoe
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
This looks good to me, can we consider enabling it for some of our API repos not just the samples repo? CC: @busunkim96?
| const obj = xmljs.xml2js(xml, { compact: true }) as xmljs.ElementCompact; | ||
| const failures: TestCase[] = []; | ||
| const passes: TestCase[] = []; | ||
| // Python doesn't always have a top-level testsuites element. |
There was a problem hiding this comment.
I'll be curious to see if we bump into similar edge-cases with Node.js.
There was a problem hiding this comment.
Me too. I imagine we will for all of the languages, which is why I included comments/tests for both languages.
|
Enabling for all of them (where desired) is the goal! |
This was referenced Feb 25, 2020
yoshi-automation
added a commit
that referenced
this pull request
Apr 1, 2020
2722ecc commit 2722ecc Author: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com> Date: Wed Jan 29 07:58:50 2020 -0500 feat(buildcop): add support for Python (#237) Python has a slightly different flavor of xUnit output. So, I updated the parsing to match (testsuites and package name handling). I switched the XML parsing to be compact. It makes iterating over the results a bit cleaner to not have to worry about 'elements'. There is no loss of accuracy for this purpose. The not-compact version only seems needed if you need stable parsing and re-printing. The Python test results also come in many different log files. So, I changed the logic for checking when a test passed to be an explicit pass rather than just not-fail. A possible downside of this is that if a failing test is renamed, the corresponding issue will not be automatically closed/renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python has a slightly different flavor of xUnit output. So, I updated
the parsing to match (testsuites and package name handling).
I switched the XML parsing to be compact. It makes iterating over the
results a bit cleaner to not have to worry about 'elements'. There is no
loss of accuracy for this purpose. The not-compact version only seems
needed if you need stable parsing and re-printing.
The Python test results also come in many different log files. So, I
changed the logic for checking when a test passed to be an explicit pass
rather than just not-fail. A possible downside of this is that if a
failing test is renamed, the corresponding issue will not be
automatically closed/renamed.