Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: showcase native check #1833

Merged
merged 9 commits into from
Jul 10, 2023
Merged

ci: showcase native check #1833

merged 9 commits into from
Jul 10, 2023

Conversation

burkedavison
Copy link
Member

No description provided.

@burkedavison burkedavison added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 7, 2023
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 7, 2023
@burkedavison
Copy link
Member Author

Expected native image failure due to missing fake_cert.pem test resource:

Failures (2):
  JUnit Vintage:ITGdch:testCreateClient_withGdchCredentialAndNoAudience_defaultsToEndpointBasedAudience
    MethodSource [className = 'com.google.showcase.v1beta1.it.ITGdch', methodName = 'testCreateClient_withGdchCredentialAndNoAudience_defaultsToEndpointBasedAudience', methodParameterTypes = '']
    => java.lang.NullPointerException
       com.google.showcase.v1beta1.it.ITGdch.prepareCredentials(ITGdch.java:95)
       com.google.showcase.v1beta1.it.ITGdch.setup(ITGdch.java:78)
       java.base@17.0.7/java.lang.reflect.Method.invoke(Method.java:568)
       org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
       org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
       org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
       org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33)
       org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
       org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
       org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
       [...]
  JUnit Vintage:ITGdch:testCreateClient_withGdchCredentialWithValidAudience_usesCredentialWithPassedAudience
    MethodSource [className = 'com.google.showcase.v1beta1.it.ITGdch', methodName = 'testCreateClient_withGdchCredentialWithValidAudience_usesCredentialWithPassedAudience', methodParameterTypes = '']
    => java.lang.NullPointerException
       com.google.showcase.v1beta1.it.ITGdch.prepareCredentials(ITGdch.java:95)
       com.google.showcase.v1beta1.it.ITGdch.setup(ITGdch.java:78)
       java.base@17.0.7/java.lang.reflect.Method.invoke(Method.java:568)
       org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
       org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
       org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
       org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33)
       org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
       org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
       org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
       [...]

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 7, 2023
@burkedavison burkedavison removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 7, 2023
@burkedavison burkedavison marked this pull request as ready for review July 7, 2023 18:26
@burkedavison burkedavison requested a review from a team as a code owner July 7, 2023 18:26
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@burkedavison burkedavison mentioned this pull request Jul 7, 2023
Closed
@burkedavison burkedavison merged commit a3e91b0 into main Jul 10, 2023
@burkedavison burkedavison deleted the showcase-native-ci branch July 10, 2023 13:07
lqiu96 pushed a commit that referenced this pull request Jul 12, 2023
@burkedavison @lqiu96
ci: showcase native check (#1833)
c9cb1e4 
* ci: showcase native check

* fix: add explicit java version

* fix: adjust syntax

* fix: add resource-config entry for ITGdch

* fix: copy file to temp folder so it can be accessed by path

* chore: formatting

* fix: prevent shutdown warnings with client.awaitTermination

* ci: fix build file location for downstream test

* chore: use static imports for Truth assertions
lqiu96 added a commit that referenced this pull request Jul 17, 2023
@lqiu96 @diegomarquezp
@emmileaf @burkedavison @release-please
fix: Use bindings for resolving multi pattern resources (#1818)
1352fab 
* fix: Use bindings for resolving multi pattern resources

* chore: Fix lint issues

* chore: Add unit tests for the behavior

* chore: Add comments for the tests

* chore: Remove unused comment

* feat: support GDC-H Credentials  (#1642)

* chore: initial additions to handle GDC-H API audience

* chore: add unit tests for GDC-H

* chore: cleanup of logic

* chore: decompose tests into separate methods

* chore: fix clirr diff check

* chore: fmt:format

* chore: add support in `ClientSettings`

* chore: add showcase IT for GDCH credentials

* chore: comments

* chore: improve tests

* chore: add partial IT for testing context credential

* chore: recreate GdchCredentials with audience using convenience method

* chore: more readable api audience logic

* chore: no wildcard imports

* chore: javadoc for public methods

* chore: gdch test to use default null initialization

* chore: tear down for gdch IT

* chore: `assertThrows` for gdch ITs

* chore: mvn fmt:format

* test: remove context test

* docs: explain that audience will be overriden if set through client/stub settings

* test: test audience setting should modify initial credentials

* chore: clirr check

* chore: ignore gdch changes

* chore: format

* chore: default to endpoint if audience not provided

* test: refresh gdch creds to confirm audience works

* chore: fmt

* chore: fmt

* chore: better test names in ClientContextTest

* chore: better test names for showcase tests

* chore: simplify refresh verification logic

* chore: include outcome in gdch it test names

* chore: expand comments in GDCH ITs

* test: intercept mock transport to verify audience

* chore: fmt

* chore: move auth test-jar to shared dependencies

* chore: cleanup

* chore: use inferred version for auth library

* deps: update google-auth-java-library to 1.19.0

* choreL fmt ITGdch.java

* chore: import auth test-jar using common version variable

* chore: remove auth test-jar import from first-party-dependencies

* chore: add license headers to new files

* chore: revert google-auth-version to be obtained from main branch

* chore: correct showcase parent pom indentation

* chore: remove resource declaration for native test build

* fix: [gapic-generator-java] handle response and metadata type ambiguity in LRO parsing (#1726)

* chore: Bump grpc-java version to 1.55.3 (#1829)

* chore: Bump gapic-showcase version to 0.28.2 (#1830)

* build(deps): Bump guava version to 32.1.1-jre (#1832)

* chore: Bump guava version to 32.1.1-jre

* chore: Add guava to gradle template

* chore: Add j2obc-annotations to shared-dependencies (#1834)

* ci: fix showcase-clirr check on release PRs (#1835)

Install sdk-platform-java before performing final clirr check, so version changes are available in the local repository

* chore(main): release 2.23.0 (#1806)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(main): release 2.23.1-SNAPSHOT (#1836)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: Implement gRPC and HttpJson showcase tests for IAM (#1789)

* chore: Add framework for iam showcase tests

* chore: Generate clients with IAM stubs

* chore: Add IAM showcase tests

* chore: Add samples

* chore: Exclude httpjson tests

* chore: Use @before to create the resource

* chore: Use constant for policy

* chore: Log resource name

* chore: Test use setPolicyRequest's resourceName

* chore: run mvn clean before showcase tests

* chore: Attempt again with cache deleted

* chore: Add logging for test

* chore: Sleep for 1s

* chore: Use resource from setPolicyRequest

* chore: Ignore failing HttpJson test for now

* chore: Un-ignore test

* chore: Fix lint issues

* chore: Test with rooms/ prefix

* chore: Use Identity client for Users

* chore: Create user resource to assign policy to

* chore: Use user's name as resource id

* chore: Change resource name before each test

* chore: Add iam-grpc in pom

* chore: Resolve sonar issues

* chore: Add comment for testIamPolicy

* chore: Address PR comments

* ci: showcase native check (#1833)

* ci: showcase native check

* fix: add explicit java version

* fix: adjust syntax

* fix: add resource-config entry for ITGdch

* fix: copy file to temp folder so it can be accessed by path

* chore: formatting

* fix: prevent shutdown warnings with client.awaitTermination

* ci: fix build file location for downstream test

* chore: use static imports for Truth assertions

* chore: Resolve merge conflicts

* chore: Use bindings for any matching resource patterns

* chore: Fix lint issues

* chore: Remove unused code

* chore: Fix lint issues

* chore: Add test for resourceName matching bindings

* chore: Fix lint issues

---------

Co-authored-by: Diego Alonso Marquez Palacios <diegomarquezp@google.com>
Co-authored-by: Emily Wang <emmwang@google.com>
Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpeddada1 mpeddada1 mpeddada1 approved these changes

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burkedavison @blakeli0 @mpeddada1