Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add comments to showcase grpc library #1929

Merged
merged 4 commits into from
Aug 20, 2023

Conversation

diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Aug 17, 2023

This was generated via mvn install -Pupdate

@diegomarquezp diegomarquezp requested a review from a team as a code owner August 17, 2023 18:36
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 17, 2023
@blakeli0
Copy link
Collaborator

LGTM. We need to be careful with the timing of merging this PR, if we merge it now and someone regenerates showcase with the existing setup, it would be overridden. Maybe try to include this change in your showcase PR?

@burkedavison
Copy link
Member

We need to be careful with the timing of merging this PR, if we merge it now and someone regenerates showcase with the existing setup, it would be overridden.

The required showcase golden tests should fail until then. Please do not merge until ci / showcase (11) and (17) tests are passing.

Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to modify the current showcase generation config to generate with comments?

@blakeli0
Copy link
Collaborator

Is it possible to modify the current showcase generation config to generate with comments?

Yeah I believe that's what Diego is working on next.

@diegomarquezp
Copy link
Contributor Author

@blakeli0 @meltsufin I included the necessary command to include comments with the current showcase configuration.

@burkedavison
Copy link
Member

@diegomarquezp : The --experimental... argument needs to also be added to the //showcase:verify_grpc configuration, directly above the //showcase:update_grpc profile you've already edited.

@diegomarquezp
Copy link
Contributor Author

thanks @burkedavison. I added the option to such profiles

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@googleapis googleapis deleted a comment from sonarcloud bot Aug 18, 2023
@googleapis googleapis deleted a comment from sonarcloud bot Aug 18, 2023
@diegomarquezp diegomarquezp merged commit 933cad5 into main Aug 20, 2023
36 checks passed
@diegomarquezp diegomarquezp deleted the showcase-grpc-comments branch August 20, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants