-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add comments to showcase grpc library #1929
Conversation
LGTM. We need to be careful with the timing of merging this PR, if we merge it now and someone regenerates showcase with the existing setup, it would be overridden. Maybe try to include this change in your showcase PR? |
The required showcase golden tests should fail until then. Please do not merge until ci / showcase (11) and (17) tests are passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to modify the current showcase generation config to generate with comments?
Yeah I believe that's what Diego is working on next. |
@blakeli0 @meltsufin I included the necessary command to include comments with the current showcase configuration. |
@diegomarquezp : The |
thanks @burkedavison. I added the option to such profiles |
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This was generated via
mvn install -Pupdate