Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): handle Java 11 set ordering differences for RPCs and fields in test/mock classes [ggj] #750

Merged
merged 11 commits into from
Jun 4, 2021

Conversation

miraleung
Copy link
Contributor

No description provided.

@miraleung miraleung requested a review from a team as a code owner June 3, 2021 00:53
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 3, 2021
@miraleung miraleung marked this pull request as draft June 3, 2021 00:53
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #750 (fccf652) into master (ddc75f9) will decrease coverage by 0.06%.
The diff coverage is 21.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
- Coverage   91.43%   91.36%   -0.07%     
==========================================
  Files         133      133              
  Lines       13874    13889      +15     
  Branches     1031     1031              
==========================================
+ Hits        12686    12690       +4     
- Misses        907      918      +11     
  Partials      281      281              
Impacted Files Coverage Δ
...google/api/generator/gapic/protoparser/Parser.java 43.63% <0.00%> (-0.97%) ⬇️
.../composer/grpc/ServiceClientTestClassComposer.java 93.59% <80.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc75f9...fccf652. Read the comment docs.

@miraleung miraleung changed the title fix(tests): Ensure tests are deterministic [ggj] fix(tests): handle Java 11 set ordering differences for RPCs and fields in test/mock classes [ggj] Jun 4, 2021
@miraleung miraleung marked this pull request as ready for review June 4, 2021 01:11
@miraleung miraleung merged commit eaf4592 into master Jun 4, 2021
@miraleung miraleung deleted the fix/nondet_tests branch June 4, 2021 15:19
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release *beep* *boop*
---


### [2.5.7](googleapis/java-core@v2.5.6...v2.5.7) (2022-03-08)


### Dependencies

* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.2.7 ([#748](googleapis/java-core#748)) ([96deaa6](googleapis/java-core@96deaa6))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants