feat(ast): Add support for Throwable causes [ggj] #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
miraleung
changed the title
Codecov Report
@@ Coverage Diff @@
## master #801 +/- ##
=======================================
Coverage 91.28% 91.29%
=======================================
Files 140 140
Lines 14965 14979 +14
Branches 1074 1078 +4
=======================================
+ Hits 13661 13675 +14
Misses 1009 1009
Partials 295 295
Continue to review full report at Codecov.
|
vam-google
approved these changes
Jul 30, 2021
|
|
||
| if (causeExpr() != null) { | ||
| Preconditions.checkState( | ||
| ConcreteReference.withClazz(Throwable.class) |
There was a problem hiding this comment.
Minor, but probably we don't have to create reference each time, and can have it as a static final constant in this class.
There was a problem hiding this comment.
Done, added to TypeNode.
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for #804.