-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(python): Run owlbot_main() when owlbot.py doesn't exist #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
requested review from
bcoe,
chingor13 and
SurferJeffAtGoogle
as code owners
October 14, 2021 14:30
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Oct 14, 2021
bcoe
approved these changes
Oct 14, 2021
This was referenced Oct 14, 2021
This was referenced Oct 25, 2021
gcf-merge-on-green bot
pushed a commit
to googleapis/python-redis
that referenced
this pull request
Oct 27, 2021
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
This was referenced Oct 27, 2021
gcf-merge-on-green bot
pushed a commit
to googleapis/python-security-private-ca
that referenced
this pull request
Oct 29, 2021
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
This was referenced Nov 3, 2021
gcf-merge-on-green bot
pushed a commit
to googleapis/python-billingbudgets
that referenced
this pull request
Nov 4, 2021
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
This was referenced Nov 6, 2021
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Apr 20, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jun 4, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jun 5, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
parthea
added a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow us to remove owlbot.py from python repositories that don't have repository specific owlbot.py customizations.
I tested the changes using the following commands after cloning synthtool
Once the docker image was built, I ran the following command in the root of python-iap which has no customimzations and python-deploy which has minor customizations. Prior to running these commands, I deleted
owlbot.py
locally.