Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception occurring due to missing "repo" field #398

Merged
merged 3 commits into from
Feb 3, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Feb 3, 2020

Some of our Node.js repos started failing due to "repo" no longer being defaulted to an empty object, see: googleapis/gaxios#231.

Would it be alright if we continue populating an empty object for the time being?

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2020
@bcoe bcoe requested a review from chingor13 February 3, 2020 20:36
synthtool/gcp/common.py Outdated Show resolved Hide resolved
synthtool/gcp/common.py Show resolved Hide resolved
@bcoe
Copy link
Contributor Author

bcoe commented Feb 3, 2020

@chingor13 fixed 😄

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint failed: synthtool/gcp/common.py:20:1: F401 'typing.Optional' imported but unused

otherwise, LGTM

@bcoe bcoe merged commit 4269521 into master Feb 3, 2020
@bcoe bcoe deleted the fix-node-templates branch February 3, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants