-
Notifications
You must be signed in to change notification settings - Fork 22
Error Handling #12
Comments
Would a general |
Yep, I think a general on-error would work great in my case. Once the error is fired, I can handle it based on the error code provided by firebase. The firebase code will tell me if permission is denied, or it is another type of data error so I can notify the user. Is that just a matter of adding an error/cancel callback to each firebase query? I can put a pull request together for that, although I haven't done that process before. Just fork and pull request? |
Yep, that's the process, although Google requires having a signed CLA on record for contributions (quick form here: https://cla.developers.google.com/clas). Although, I basically put this together yesterday, but didn't have a chance to mock up errors to test it... how about I'll put the PR up and you can test it on your end? Pull request here: #13 Just checkout the |
Fixes #12. Add on-error event for error handling.
Great library and great combination of the power of Polymer and Firebase!
I realize its still early days, but adding a way to listen to errors (such as permission denied) would help a lot so we can notify the user and handle flow.
Thanks for your work!
The text was updated successfully, but these errors were encountered: