Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Error Handling #12

Closed
jshortall opened this issue Oct 21, 2014 · 3 comments
Closed

Error Handling #12

jshortall opened this issue Oct 21, 2014 · 3 comments

Comments

@jshortall
Copy link
Contributor

Great library and great combination of the power of Polymer and Firebase!

I realize its still early days, but adding a way to listen to errors (such as permission denied) would help a lot so we can notify the user and handle flow.

Thanks for your work!

@kevinpschaaf
Copy link
Contributor

Would a general on-error fired based on any error received back from Firebase meet your use case? That would be pretty trivial to add. Being able to tie the error back to the action that caused it is tricky given actions happen based on data mutation. I can add the former if that helps.

@jshortall
Copy link
Contributor Author

Yep, I think a general on-error would work great in my case. Once the error is fired, I can handle it based on the error code provided by firebase. The firebase code will tell me if permission is denied, or it is another type of data error so I can notify the user.

Is that just a matter of adding an error/cancel callback to each firebase query? I can put a pull request together for that, although I haven't done that process before. Just fork and pull request?

@kevinpschaaf
Copy link
Contributor

Yep, that's the process, although Google requires having a signed CLA on record for contributions (quick form here: https://cla.developers.google.com/clas). Although, I basically put this together yesterday, but didn't have a chance to mock up errors to test it... how about I'll put the PR up and you can test it on your end?

Pull request here: #13

Just checkout the issue-12-error-handling branch.

addyosmani added a commit that referenced this issue Oct 25, 2014
Fixes #12. Add on-error event for error handling.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants