core(metrics): rename ConsistentlyInteractive -> Interactive #5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
force-pushed
the
rename_interactive
branch
from
bbd5055
to
001d903
Compare
paulirish
requested changes
Apr 30, 2018
| helpText: 'Consistently Interactive marks the time at which the page is ' + | ||
| 'fully interactive. ' + | ||
| name: 'interactive', | ||
| description: 'Interactive', |
There was a problem hiding this comment.
IMO this should be called the full "Time to Interactive" in the UI. even if there's inconsistency, that's the name.
| @@ -84,7 +84,7 @@ module.exports = { | |||
| 'errors-in-console', | |||
| 'time-to-first-byte', | |||
| 'first-cpu-idle', | |||
| 'consistently-interactive', | |||
| 'interactive', | |||
There was a problem hiding this comment.
i do prefer 'time-to-interactive' personally, but i could could live with this slug if i had to.
brendankenny
approved these changes
Apr 30, 2018
paulirish
approved these changes
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renames
consistently-interactive->interactiveno other metric has
time toin its implementation even though all of thefirst*metrics are alsotime tometrics, for consistency I'm proposing justinteractive. Feel free to continue to use TTI to describe it, but seems silly to be the only one to do so when referring to its full name :)ref #4629