core(tsc): fancier displayValue type #5111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
May 4, 2018
paulirish
changed the title
brendankenny
changed the title
kdzwinel
pushed a commit
to kdzwinel/lighthouse
that referenced
this pull request
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsc wasn't inferring the correct type for displayValue in #5099 (widening it to just
Array<string | number>which doesn't fit our requirement that the first element always be a string). It turns out this was because it was losing track of the more specific array type when passing back up the promise chain.Flattening execution a bit with async/await and it can track the more specific type again :)
Diff is relatively tiny if you look at ?w=1