Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta description #19

Closed
hnordt opened this issue Jan 2, 2019 · 7 comments
Closed

meta description #19

hnordt opened this issue Jan 2, 2019 · 7 comments

Comments

@hnordt
Copy link

hnordt commented Jan 2, 2019

It would be nice to read description from the manifest and add it as <meta name="description" /> if that tag is not already present.

@samthor
Copy link
Contributor

samthor commented Jan 9, 2019

I could do this but I'm not sure of the added value. I suspect most sites that are reading this kind of meta from the HTML itself aren't running the page's JS—think e.g., sharing a link on Twitter.

Is there another reason why this might be useful?

@hnordt
Copy link
Author

hnordt commented Jan 9, 2019

The main reason is to avoid this Lighthouse's warning:

Img

https://developers.google.com/web/tools/lighthouse/audits/description

@samthor
Copy link
Contributor

samthor commented Jan 9, 2019

I really believe that most crawlers/etc are not going to run page JavaScript just to read your site's meta tags.

So while it might make Lighthouse happy, I suspect this change won't actually improve your SEO.

@hnordt
Copy link
Author

hnordt commented Jan 9, 2019

I understand your point, but I'm not sure it would be a bad thing. You could just check if there is a meta description already and add one based on manifest if not.

Just as theme_color, I don't like to have to duplicate it on my HTML head.

@Malvoz
Copy link

Malvoz commented Jan 9, 2019

Unlike <title> (under some circumstances) a <meta> description isn't required in HTML. If you don't need it, should you add it just to appease the Lighthouse tool?

I really believe that most crawlers/etc are not going to run page JavaScript just to read your site's meta tags.

So while it might make Lighthouse happy, I suspect this change won't actually improve your SEO.

I haven't googled it but I'm quite sure Google can index script-generated content, however if Google saw the same <meta> description across several pages then the site-owner may start worrying about "SEO penalties" due to duplicate content.

Personally I don't think this is a good default for PWACompat.

@samthor
Copy link
Contributor

samthor commented Jan 18, 2019

Sorry @hnordt but I also don't think this is worth including.

PWACompat is not intended to help with search indexability. I've had #22 filed and I'll mention this as part of resolving that issue.

@samthor samthor closed this as completed Jan 18, 2019
@hnordt
Copy link
Author

hnordt commented Jan 18, 2019

Thank you for having a look at it @samthor. I agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants