Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendoring is broken #10

Closed
proppy opened this issue Jun 12, 2014 · 1 comment · Fixed by #12
Closed

vendoring is broken #10

proppy opened this issue Jun 12, 2014 · 1 comment · Fixed by #12

Comments

@proppy
Copy link
Member

proppy commented Jun 12, 2014

For package vendoring dependencies, (like coreos/etcd) nested dependencies will never get resolved locally, as the import path is app, instead of the fully qualified one.

A proper solution is to allow package who vendor dependencies to specify their original import path with a .godir text file or through Godeps, and default on app only if the fully qualified import path cannot be infered.
proppy added a commit to proppy/golang-docker that referenced this issue Jun 12, 2014
@proppy
runtime: refactor vendoring handling
5ed0118 
- add .godir for defining import path
- move deps to vendored import path under hello app

Fixes: GoogleCloudPlatform#10
@proppy proppy mentioned this issue Jun 12, 2014
Merged
@proppy
Copy link
Member Author

proppy commented Jun 16, 2014

Should be fixed with #12.

@proppy proppy closed this as completed Jun 16, 2014
@proppy proppy mentioned this issue Aug 25, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime: refactor vendoring handling proppy/golang-docker
1 participant
@proppy