This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Always print out the nested command on failure. #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojarjur
reviewed
Feb 12, 2018
tools/cli/datalab.py
Outdated
| print('A nested call to gcloud failed.') | ||
| print('Command: ["' + '","'.join(e.cmd) + '"]') |
There was a problem hiding this comment.
I feel like this should be under an if utils.print_debug_messages(args): condition, so that we don't doubly spam users when the cause of the failure has already been reported.
I also think we should probably make the get_gcloud_zone and get_email_address methods print their stdout/stderr if they fail.
ojarjur
previously approved these changes
Feb 12, 2018
|
Fixed flake8 errors. PTAL |
ojarjur
approved these changes
Feb 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way users will always have at least something to look at when we report that a gcloud command fails.