Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check ligatures are consistent #2747

Open
davelab6 opened this issue Feb 2, 2020 · 5 comments
Open

Check ligatures are consistent #2747

davelab6 opened this issue Feb 2, 2020 · 5 comments
Assignees
Labels
Blocked - waiting for some feedback New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P2 Important

Comments

@davelab6
Copy link
Contributor

davelab6 commented Feb 2, 2020

Observed behaviour

https://twitter.com/mjdye/status/1223762539768467456?s=19

So, I’m playing around with @EbenSorkin 's Gelasio on google fonts and have noticed ligatures are weirdly inconsistent. See screenshot. Is that a mistake or is that intentional? https://t.co/UaXivIpZ1z

IMG_20200201_200959

Expected behaviour

Ligatures should be technically checked for existing, and visually checked for similarities. The latter might be more of an exq thing

@felipesanches
Copy link
Collaborator

could you please clarify "exq thing"?

@felipesanches
Copy link
Collaborator

Are we discussing here a proposal of a check specific to fi-fl-ffi-ffl ligatures?

Or are we talking bout a broader issue that involves a larger set of potential ligatures?

@felipesanches
Copy link
Collaborator

felipesanches commented Feb 2, 2020

also...

  • "checked for existing" sounds like something easily scriptable as long as we have a list of pairs to check against
  • "visually checked for similarities" sounds like a task for actual human type-designers to do so it might be dashboard-level.

@davelab6
Copy link
Contributor Author

davelab6 commented Feb 12, 2020 via email

@EbenSorkin
Copy link

Yeah this could be an EQX pass fail question or possibly 2+ basic questions which build to a family consistency question. I'll have a look at this post Merriweather and revise the source. For some reason I don't recall if I made Gelasio into a VF. If I somehow didn't I'll do that as well.

@felipesanches felipesanches added the New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id label Mar 6, 2020
@felipesanches felipesanches removed this from the 0.8.x series milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked - waiting for some feedback New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P2 Important
Projects
None yet
Development

No branches or pull requests

3 participants