Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicodes of a glyph with multiple unicodes parsed as list of lists ?! #696

Closed
wants to merge 1 commit into from

Conversation

jansindl3r
Copy link

this solves a problem where unicodes were parsed as list of lists of one child in a file saved glyphs 3.0.3 (3091). Please check it

…one child in a file saved glyphs 3.0.3 (3091)
@google-cla
Copy link

google-cla bot commented Jul 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jansindl3r
Copy link
Author

sorry, my tests failed, but they failed even right after cloning it

@jansindl3r
Copy link
Author

@googlebot I signed it!

@jansindl3r
Copy link
Author

jansindl3r commented Jul 16, 2021

Template.glyphs.zip
This is the file that caused the latest version of glyphsLib to crash

Copy link
Collaborator

@schriftgestalt schriftgestalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is the right place to fix this. Where do the nested list comes from?

@jansindl3r
Copy link
Author

@schriftgestalt you are right! But I didn't really find where it comes from

@jansindl3r jansindl3r closed this by deleting the head repository Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants