Assert uniqueness of all IDs #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ouch. Good catch. "Beninese Yoruba" should be "Yoruba, Benin". |
|
Good point. "Language, Place (Script)" is the new schema. |
nathan-williams
approved these changes
Aug 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that shaperglot was using
yo_Latn_BJinstead ofyo_Latn, which was odd. Then we noticed that both languages were calledYorubabut this wasn't caught by #154, which was very odd. Then I realised that both textproto files had anid:field ofyo_Latn, so the Beninese Yoruba was overriding the Nigerian Yoruba. Oops.It turns out we had a few other languages with duplicated IDs too.