Bump gRPC version. #56
Conversation
| @@ -98,7 +98,6 @@ private static Channel getGenomicsChannel() throws SSLException { | |||
|
|
|||
| Channel channel = NettyChannelBuilder.forAddress("genomics.googleapis.com", 443) | |||
| .negotiationType(NegotiationType.TLS) | |||
| .streamWindowSize(1000000) | |||
There was a problem hiding this comment.
You have verified this is no longer necessary for performance, I take it?
There was a problem hiding this comment.
@ssgross There is a different method to set that value now. See https://github.com/grpc/grpc-java/blob/master/netty/src/main/java/io/grpc/netty/NettyChannelBuilder.java#L126
But since the default is 1048576, which is roughly equivalent to what was in the file, I took it out. See https://github.com/grpc/grpc-java/blob/master/netty/src/main/java/io/grpc/netty/NettyChannelBuilder.java#L54
Let me know if you think we should continue to set it explicitly.
There was a problem hiding this comment.
No, that's fine, the default used to be much lower so I guess they raised it.
|
LGTM modulo streamWindowSize comment. |
These come in through the grpc-java dependency.
|
@ssgross I added one more commit that removes some redundant code per @elmer-garduno. code-gen, unit tests, and integration tests all pass. PTAL. |
|
LGTM |
No description provided.