Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Add a note for Eclipse users and local builds. #59

Merged
merged 4 commits into from
Sep 3, 2015
Merged

Conversation

deflaux
Copy link
Contributor

@deflaux deflaux commented Sep 3, 2015

@dloy please take a look

@jean-philippe-martin it might be helpful if you add similar instructions for intelliJ?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jean-philippe-martin
Copy link
Contributor

@deflaux, can do.

@jean-philippe-martin
Copy link
Contributor

I find those instructions a little bit confusing, because the Eclipse instructions say "First update the dependencies in your poms to point to the SNAPSHOT versions as mentioned above." but it's not clear that one should only do that if they want to work on multiple repos at once. The section's title is just "Building this project".

@deflaux
Copy link
Contributor Author

deflaux commented Sep 3, 2015

@jean-philippe-martin ptal


1. Build and install the jar to your local maven repository via `mvn install`.
2. Then update the pom.xml of the dependent project to temporarily depend upon the particular SNAPSHOT version of utils-java now installed in your local maven repository.

3. Eclipse users:
* First update the dependencies in your poms to point to the SNAPSHOT versions as mentioned above.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with Maven other than 'mvn install' =). Do you have a pointer or clarification on the SNAPSHOT version stuff? (just append -SNAPSHOT to the current version, or is something else required here?).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't (3.a) redundant with point (2)? I think we can just remove it. Other than that, the indentation totally cleared up the confusion, thank you!

@deflaux
Copy link
Contributor Author

deflaux commented Sep 3, 2015

How's this version? The basic idea is that maven reads from the local maven repository. Eclipse will do its own build, but it can figure out the dependencies from the pom file. I tend to use both together, as a sanity check.

Please feel free to tweak the wording so that it is more clear. Also, we can dig up links to the maven documentation and eclipse documentation. None of this is specific to genomics, but it is really helpful to give people the cookbook summary right here!

@dionloy
Copy link

dionloy commented Sep 3, 2015

LGTM Thanks!

On Thu, Sep 3, 2015 at 11:20 AM, Nicole Deflaux notifications@github.com
wrote:

How's this version? The basic idea is that maven reads from the local
maven repository. Eclipse will do its own build, but it can figure out the
dependencies from the pom file. I tend to use both together, as a sanity
check.

Please feel free to tweak the wording so that it is more clear. Also, we
can dig up links to the maven documentation and eclipse documentation. None
of this is specific to genomics, but it is really helpful to give people
the cookbook summary right here!


Reply to this email directly or view it on GitHub
#59 (comment)
.

deflaux added a commit that referenced this pull request Sep 3, 2015
Add a note for Eclipse users and local builds.
@deflaux deflaux merged commit bd3d6b3 into master Sep 3, 2015
@deflaux deflaux deleted the deflaux-patch-1 branch September 18, 2015 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants