-
Notifications
You must be signed in to change notification settings - Fork 11
Add a note for Eclipse users and local builds. #59
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@deflaux, can do. |
I find those instructions a little bit confusing, because the Eclipse instructions say "First update the dependencies in your poms to point to the SNAPSHOT versions as mentioned above." but it's not clear that one should only do that if they want to work on multiple repos at once. The section's title is just "Building this project". |
|
||
1. Build and install the jar to your local maven repository via `mvn install`. | ||
2. Then update the pom.xml of the dependent project to temporarily depend upon the particular SNAPSHOT version of utils-java now installed in your local maven repository. | ||
|
||
3. Eclipse users: | ||
* First update the dependencies in your poms to point to the SNAPSHOT versions as mentioned above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with Maven other than 'mvn install' =). Do you have a pointer or clarification on the SNAPSHOT version stuff? (just append -SNAPSHOT to the current version, or is something else required here?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't (3.a) redundant with point (2)? I think we can just remove it. Other than that, the indentation totally cleared up the confusion, thank you!
How's this version? The basic idea is that maven reads from the local maven repository. Eclipse will do its own build, but it can figure out the dependencies from the pom file. I tend to use both together, as a sanity check. Please feel free to tweak the wording so that it is more clear. Also, we can dig up links to the maven documentation and eclipse documentation. None of this is specific to genomics, but it is really helpful to give people the cookbook summary right here! |
LGTM Thanks! On Thu, Sep 3, 2015 at 11:20 AM, Nicole Deflaux notifications@github.com
|
Add a note for Eclipse users and local builds.
@dloy please take a look
@jean-philippe-martin it might be helpful if you add similar instructions for intelliJ?