This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
Refactor Auth. #76
Merged
Refactor Auth. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deflaux
commented
Dec 11, 2015
deflaux
commented
- Use Application Default Credentials by default for both the Genomics REST and gRPC APIs.
- Refactor GenomicsFactory to extract credential creation and OfflineAuth to separate files since that logic is also used by gRPC.
- Remove API key support in gRPC now that authentication is required.
Also remove support for API keys in gRPC since authentication is now a requirement.
|
LGTM (previously reviewed) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.