Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating libraries #377

Merged
merged 9 commits into from
Sep 27, 2023
Merged

chore: updating libraries #377

merged 9 commits into from
Sep 27, 2023

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Aug 10, 2023

This PR updates some libraries on Android Maps Compose:

  • Material
  • Maps
  • JUnit KTX
  • Espresso
  • Coroutines
  • Android Maps Utils

This PR introduces a breaking change after updating to Android Maps Utils 3.5.2. This version was not marked on Android Maps Utils as a major release, but it does change the interface on ClusterItem (now the z index is required, see message here), so we should consider a release marking a breaking change here.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #376
Fixes #288

@wangela
Copy link
Member

wangela commented Aug 10, 2023

Due to the breaking change, let's merge this after this week's other pending PRs.

Copy link
Member

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for others to merge before this breaking change.

gradle/libs.versions.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
@kikoso kikoso requested a review from a team as a code owner September 26, 2023 15:56
gradle/libs.versions.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@wangela wangela merged commit 16cd89e into main Sep 27, 2023
10 checks passed
@wangela wangela deleted the chore/update_libraries branch September 27, 2023 19:45
wangela pushed a commit that referenced this pull request Oct 3, 2023
chore: update JDK in release workflow (#419)

feat: add custom ClusterRenderer (#360)

chore: update to Maps KTX v4.0.0 (Maps SDK for Android v18.1.0, Maps Utils v3.5.3), Kotlin 1.9.0, and other dependencies (#377)

BREAKING CHANGE: remove guidance to specify Maps SDK for Android and Utility Library dependencies alongside Maps Compose. These dependencies are pulled in by the Maps Compose build script to ensure version compatibility.
googlemaps-bot pushed a commit that referenced this pull request Oct 3, 2023
# [3.0.0](v2.15.0...v3.0.0) (2023-10-03)

### breaking

* simplify dependencies ([9456fec](9456fec)), closes [#419](#419) [#360](#360) [#377](#377)

### Reverts

* Revert "chore: update semantic-release config (#416)" (#417) ([dff9276](dff9276)), closes [#416](#416) [#417](#417)

### BREAKING CHANGES

* remove guidance to specify Maps SDK for Android and Utility Library dependencies alongside Maps Compose. These dependencies are pulled in by the Maps Compose build script to ensure version compatibility.
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants