Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use api instead of implementation. #10

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

arriolac
Copy link
Contributor

Using api instead of implementation so that consumers can include this library
without needing to also include the AMU library.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 11, 2020
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #10 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #10   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           9       9           
  Lines          92      92           
  Branches       18      18           
======================================
  Misses         92      92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96817f9...7659d7c. Read the comment docs.

@arriolac
Copy link
Contributor Author

Merging this in. @barbeau lmk if you have any comments about it—we can address separately.

@arriolac arriolac merged commit ac40f46 into master Mar 11, 2020
@arriolac arriolac deleted the chris/fix/api_implementation branch March 11, 2020 23:25
@barbeau
Copy link
Contributor

barbeau commented Mar 12, 2020

LGTM!

googlemaps-bot pushed a commit that referenced this pull request Apr 2, 2020
# 1.0.0 (2020-04-02)

### Bug Fixes

* Add dependencies of maps-utils-ktx in pom. ([#14](#14)) ([d2f14e4](d2f14e4))
* next repositories inside publishing ([38e8dbc](38e8dbc))
* Use api instead of implementation. ([#10](#10)) ([ac40f46](ac40f46))

### Features

* Adding ability to publish to maven central ([#5](#5)) ([5cfa6b1](5cfa6b1))
* Adding KTX to Maps SDK ([#21](#21)) ([3313167](3313167))
* Adding PolyUtil extensions to List<LatLng> ([#16](#16)) ([d4cd6f5](d4cd6f5))
* Create maps-ktx module ([#20](#20)) ([597a70c](597a70c))

### BREAKING CHANGES

* Moved KTX for utils from com.google.maps.android.ktx to
com.google.maps.android.ktx.utils to avoid package name conflicts with
the new maps-ktx module.

* refactor: move core extensions to separate package.

* Using shared version.

* Adjusting settings.gradle.
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants