Fix problem with parse pair element ("key") and make mapOverlays function public #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemBoboshko
changed the title
|
This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you! |
|
@domesticmouse Looking forward to having it checked. |
googlebot
added
the
cla: yes
arriolac
suggested changes
Jan 8, 2020
| /** | ||
| * The overlays array returned from the GMUGeometryRenderer, use after render function. | ||
| */ | ||
| - (NSArray<GMSOverlay *> *)mapOverlays; |
There was a problem hiding this comment.
Please revert this change. The mapOverlays function defined in GMUGeometryRenderer.m was not designed to be exposed in the public interface.
If you need access to this, I recommend creating a class extension similar to GMUGeometryRenderer+Testing.h to expose this method.
| @@ -15,3 +15,4 @@ Michael Lapuebla <chainedtothewoods@gmail.com> | |||
| Daniel Kostrzynski <kostrzynski@google.com> | |||
| Christian Ihle <blurpy@gmail.com> | |||
| Gareth Pearce <garethpearce@google.com> | |||
| Artem Boboshko <boboshkoa@meta.ua> | |||
There was a problem hiding this comment.
Looks like there are some conflicts in this file that need to be addressed.
|
Opened #259 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216. I noticed that GMUKMLParser don't parse and don't save GMUPair objects to GMUStyleMap.
So i've added this logic to the GMUKMLParser.
Also, I faced with an issue that I can't make my overlays tappable after I used GMUGeometryRenderer to render geometries.
I found
mapOverlaysfunction that are not used. I think this function were made to be public but it's not in h file for some reasons.I've made it public.
@domesticmouse Looking forward to have it merged.
Thanks.
Test passing
CLA submitted