Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support for Advanced markers (AdvancedMarkerView) #803

Merged
merged 7 commits into from
Jun 14, 2023

Conversation

chrisjshull
Copy link
Contributor

fixes #802

src/index.ts Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
@chrisjshull
Copy link
Contributor Author

chrisjshull commented Jun 13, 2023 via email

@vicb
Copy link

vicb commented Jun 13, 2023

Yes, it can give people more control over caching.

Interesting... is that documented somewhere? (I don't really understand what can be controlled here?)

@chrisjshull
Copy link
Contributor Author

chrisjshull commented Jun 13, 2023 via email

@vicb
Copy link

vicb commented Jun 13, 2023

Doesn't that make my point even more valid?

You are more likely to have a cache hit if the url doesn't specify any library (as it will be common whatever set of lib you use).

That's possible because the loader importLibrary of all individual library anyway.

(Though it probably depends on how google.maps.importLibrary is implemented)

@chrisjshull chrisjshull changed the title Fix: Support for Advanced markers (AdvancedMarkerView) fix: Support for Advanced markers (AdvancedMarkerView) Jun 13, 2023
@amuramoto amuramoto merged commit a7a93d1 into googlemaps:main Jun 14, 2023
14 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
* update examples and minimize URLs

* fix: add unit test for valid URL generation

* Fix: Support for Advanced markers (AdvancedMarkerView) #802

* formatting fix

* clarify comment a7a93d1
googlemaps-bot pushed a commit that referenced this pull request Jun 14, 2023
### [1.16.2](v1.16.1...v1.16.2) (2023-06-14)

### Bug Fixes

* Support for Advanced markers (AdvancedMarkerView) ([#803](#803)) ([a7a93d1](a7a93d1)), closes [#802](#802)

### Miscellaneous Chores

* Add a unit test for valid URL generation ([#800](#800)) ([9a13708](9a13708))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 1.16.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Advanced markers (AdvancedMarkerView)
5 participants