Skip to content
This repository was archived by the owner on Sep 20, 2019. It is now read-only.

Conversation

wkmeijer
Copy link

@wkmeijer wkmeijer commented Jun 2, 2017

This minor change fixes the display of black bars on multiple devices, caused by a wrongly set aspect ratio. This should fix the problems mentioned in issues #69 #66 and possibly #38 and #9 .

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@wkmeijer
Copy link
Author

wkmeijer commented Jun 2, 2017

Signed it.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jun 2, 2017
@PoloShock
Copy link

This results in cropped preview on my Sony Xperia Z3 Tablet Compact.
More specifically, there is only part of the original preview after applying the change. The rest is not displayed since it doesn't fit.

Copy link

@ShreyashPromact ShreyashPromact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some devices, it looks like working fine and for some it not.

@returnZro
Copy link

This fix just crops the image of higher resolution in preview. When you retrieve the saved image, its not what exactly shown in the preview.

@yudikarma
Copy link

@rameshbabudevalingam hei, you get some idea to fix that ? i hava some problem cause my imagesave not what exactly shown in the preview. thanks

@codingjeremy
Copy link
Contributor

This sample has been migrated to a new location where we can accept Pull Requests (check README for more information).

As recommended by GitHub, we are closing all issues and pull requests now that this older repo will be archived.

If you still see this issue in the updated repo, please reopen the issue/PR there. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants