Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin branch - Fixing config change bug #574 - no more AndroidViewModels #635

Merged

Conversation

Projects
None yet
3 participants
@JoseAlcerreca
Copy link
Contributor

commented Feb 27, 2019

Kotlin version of #631

@JoseAlcerreca JoseAlcerreca requested a review from keyboardsurfer Feb 28, 2019

@dazza5000
Copy link

left a comment

Circle says there were some failed tests

@dazza5000

This comment has been minimized.

Copy link

commented Mar 1, 2019

Are the firebase test lab results public? I was unable to see them.

@JoseAlcerreca

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

@dazza5000 yeah currently there are two issues:

  • There's flakiness that only happens in FTL
  • The script only downloads test results if the tests succeed

@JoseAlcerreca JoseAlcerreca merged commit bb16cb0 into todo-mvvm-live-kotlin Mar 1, 2019

1 of 4 checks passed

ci/circleci: build_and_setup CircleCI is running your tests
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
cla/google All necessary CLAs are signed

@JoseAlcerreca JoseAlcerreca deleted the todo-mvvm-live-kotlin_androidviewmodel branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.