Skip to content

Kotlin branch - Fixing config change bug #574 - no more AndroidViewModels #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoseAlcerreca
Copy link
Contributor

Kotlin version of #631

Copy link

@dazza5000 dazza5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle says there were some failed tests

@dazza5000
Copy link

Are the firebase test lab results public? I was unable to see them.

@JoseAlcerreca
Copy link
Contributor Author

@dazza5000 yeah currently there are two issues:

  • There's flakiness that only happens in FTL
  • The script only downloads test results if the tests succeed

@JoseAlcerreca JoseAlcerreca merged commit bb16cb0 into todo-mvvm-live-kotlin Mar 1, 2019
@JoseAlcerreca JoseAlcerreca deleted the todo-mvvm-live-kotlin_androidviewmodel branch May 6, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants