Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues with Android Studio #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vijmax
Copy link

@vijmax vijmax commented Jul 26, 2019

Pull the sample project from Android studio as is and the build fails

Pull the sample project from Android studio as is and the build fails
@@ -30,4 +36,5 @@ dependencies {
implementation "com.android.support:leanback-v17:$appCompatVersion"
implementation "com.android.support:appcompat-v7:$appCompatVersion"
implementation 'com.google.android.exoplayer:exoplayer:r1.5.14'
implementation 'com.android.support:support-annotations:28.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be at the same appCompatVersion version?

@vijmax
Copy link
Author

vijmax commented Jul 29, 2019 via email

@Fleker
Copy link
Contributor

Fleker commented Jul 30, 2019

In multiple places we use a single constant for all app compat versions, ie. implementation "com.android.support:appcompat-v7:$appCompatVersion" If we can do the same in this new line, that would be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants