Adds modular pipe ends #17268
Merged
Adds modular pipe ends #17268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes images to no longer use non-modular pipes adjusts certain images to accomadate varying colours Removes icon states that are no longer useful Modular pipe ends can be coloured and hidden Adds a caching system for the modular pipes Some more things I'm probably forgetting
…nto pipeunderlays
…nto pipeunderlays
the furnace connector now uses modular pipes
…nto pipeunderlays
adds extra types so they dont have to be varedited Uses map icons using the IN_MAP_EDITOR define
boring-cyborg
bot
added
the
C-Sprites
keywordlabeler
bot
added
A-Atmospherics
github-actions
bot
added
the
size/XL
github-actions
bot
added
size/XXL
|
hello yes please review well i probably missed something |
amylizzle
approved these changes
Dec 15, 2023
This was referenced Dec 19, 2023
This was referenced Dec 20, 2023
goonstation-issuebot
removed
the
S-Testmerged
github-actions
bot
added
the
S-Merge-Conflict
github-actions
bot
removed
the
S-Merge-Conflict
TobleroneSwordfish
added
E-DNM
|
Was the revert of #17334 intentional? |
no not particularly |
|
mapmerge was being funky so im blaming that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ATMOSPHERICS][INTERNAL][CLEAN]
About the PR
Adds modular pipe ends, pipe underlays that can be easily changed to shown, hidden, or exposed. They can also have colors based on what they are connected to.
They use the format SET_PIPE_UNDERLAY(the node being connected to, the dir, size of pipe when exposed which can be "short" "medium" or "long", color of pipe, hide or show the pipe)
Gives it a icon cache so memory and perf is saved.
Adds icon map versions for atmos devices since we kinda don't want a valve with no pipe being shown in SDMM.
Adds subtypes so people don't have to varedit to the map icon they need. Adds these types to maps.
Changes the indicator on the pump and the dual vent so they don't get masked by the pipe color.
Manifolds now have consistent node directions so I don't have to deal with bits on this.
Why's this needed?
Makes it so much easier to edit icons, as you don't need to add pipes onto each state.
Improves consistency, as the pipes are centralised in one file.
Helps out mappers a bit so they need to do less varediting.
Changelog