Add template feature #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschulz
force-pushed
the
feature/templates
branch
from
98336b1
to
2084587
Compare
metalmatze
suggested changes
Apr 5, 2017
action/edit.go
Outdated
| @@ -8,6 +8,9 @@ import ( | |||
| "os" | |||
| "os/exec" | |||
|
|
|||
| "github.com/justwatchcom/gopass/pwgen" | |||
| "github.com/justwatchcom/gopass/tpl" | |||
|
|
|||
There was a problem hiding this comment.
This new line is one too much.
action/edit.go
Outdated
| } else if tmpl, found := s.Store.LookupTemplate(name); found { | ||
| changed = true | ||
| // load template if it exists | ||
| content = pwgen.GeneratePassword(24, false) |
There was a problem hiding this comment.
Maybe the default 24 should be a const shared across packages or passed down. Aren't we setting that somewhere else too?
There was a problem hiding this comment.
Yes, indeed. Will change that.
metalmatze
approved these changes
May 17, 2017
This was referenced May 4, 2021
Closed
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a handy template / preset feature for your password store.