-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIME rendering #110
Closed
Closed
MIME rendering #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to mime-rendering Conflicts: kernel.go
Ran into trouble with cosmos72/gomacro#16. A lot of the rendering logic requires type assertions and unfortunately many of those are interfaces. |
Not at all! You know gomacro's capabilities much better than I do :) I'll move the discussion over there. |
as per discussion in #105, I merged that pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for rendering richer displays of data in the notebook. The approach was designed to follow IPython's API as far as it applies in Go. Any code that needs access to the kernel should be injected right before evaluation but generic user space stuff should go in the
runtime
package.An example I've been playing around with is below.
There is still a bug I can't quite track down yet with the zmq message being somehow corrupted during Publish and so in random cases the results may or may not show up due to the message being rejected (which means if it doesn't work try it a second time until this is fixed).(Fixed in 710233f)Still TODO: