Go 1.11 module support #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les: import "/path/to/some/package" is now module-aware * require Go compiler >= 1.11, the first version with modules support * delete vendor/ directory, replaced by versioned dependencies in go.mod
This was referenced Nov 28, 2019
kortschak
reviewed
Nov 29, 2019
imports/a_package.go
Outdated
|
|
||
| import ( | ||
| "github.com/cosmos72/gomacro/base/paths" | ||
| i "github.com/cosmos72/gomacro/imports" |
There was a problem hiding this comment.
Any particular reason for this import rename?
There was a problem hiding this comment.
Technically, it's not required.
I just preferred not to import a package named "imports" from another package named "imports" too.
Maybe something like "base" or "baseimports" is clearer?
There was a problem hiding this comment.
It shouldn't be a concern. There's no conflict since a package never sees its own name, and this file is very small, so there's no confusion.
There was a problem hiding this comment.
ok, replaced the import i "..." with a plain import "..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import "/path/to/some/package" is now module-aware
Open for review & testing