Move storeutil package to example/todomvc/store. #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like CI is failing since it runs: Also, we'll need to make a note in |
It has been moved into example directory, which is already listed. Use import path pattern for all other entries for consistency.
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 52.09% 53.96% +1.86%
==========================================
Files 5 4 -1
Lines 405 391 -14
==========================================
Hits 211 211
+ Misses 178 164 -14
Partials 16 16Continue to review full report at Codecov.
|
|
PTAL. |
|
Looks great, thanks for sending this @shurcooL ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://godoc.org/github.com/gopherjs/vecty/storeutil?importers,
todomvcis the only user of it.Resolves #137. /cc @slimsag