add expired assertion in Get function, refactor Upsert and fix tests #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descripcion
El principal objetivo es lograr realizar un assertion de la expiración de la key antes de devolver la información al usuario.
Por otro lado se encontró algunos posibles refactor al Upsert method y fix sobre distintos tests que no estaban pasando.
Issue Relacionada
https://github.com/gophers-latam/GoKey/projects/1#card-60712576
Motivacion y Contexto
Insertar una comprobacion de expiracion antes de efectuar un get
Como fue probado
make test
provisto en el proyectoScreenshots / capturas de pantalla (si es necesario)
Tipo de cambio
Checklist
master
!.master
(lado izquierdo). Tambien de que estas usando los ultimos cambios enmaster
.go mod tidy && go mod vendor
go fmt -s
go vet