Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't define GopPackage for main package #401

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

xushiwei
Copy link
Member

@xushiwei xushiwei commented Mar 8, 2024

No description provided.

Copy link

qiniu-x bot commented Mar 8, 2024

[Git-flow] Hi @xushiwei, There are some suggestions for your information:


Rebase suggestions

  • Following commits have duplicated messages

    unused params

    unused params

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (74e2e38) to head (8d818e1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          15       15           
  Lines        6069     6069           
=======================================
  Hits         5833     5833           
  Misses        180      180           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiwei xushiwei merged commit 6ff7f61 into goplus:main Mar 8, 2024
8 checks passed
xushiwei added a commit to xushiwei/gop that referenced this pull request Mar 8, 2024
xushiwei added a commit to xushiwei/gop that referenced this pull request Mar 8, 2024
xushiwei added a commit to goplus/gop that referenced this pull request Mar 8, 2024
don't define GopPackage for main package goplus/gogen#401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant