gopls/internal/lsp/source/completion: unimport check gop overload #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
visualfc
commented
Feb 2, 2024
•
visualfc
commented
- unimported support Go/Go+ overload index/gopo, overload func snip type from first valid exported func list.
- testdata: add index/gopo overload godef/unimported check
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## goplus #182 +/- ##
==========================================
- Coverage 46.64% 46.45% -0.19%
==========================================
Files 12 12
Lines 1610 1610
==========================================
- Hits 751 748 -3
- Misses 782 784 +2
- Partials 77 78 +1 ☔ View full report in Codecov by Sentry. |
visualfc
force-pushed
the
completion_other
branch
3 times, most recently
from
62b35c6
to
a438af6
Compare
visualfc
force-pushed
the
completion_other
branch
from
a438af6
to
299da0c
Compare
visualfc
force-pushed
the
completion_other
branch
from
299da0c
to
c643c56
Compare
visualfc
force-pushed
the
completion_other
branch
from
5ffd724
to
3e4c31c
Compare
visualfc
changed the title
visualfc
force-pushed
the
completion_other
branch
from
43a0831
to
4c67aac
Compare
…opo overload decl from go
visualfc
force-pushed
the
completion_other
branch
from
081a564
to
1031232
Compare
visualfc
force-pushed
the
completion_other
branch
from
1031232
to
9cda23a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.