Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pixel aliases #7

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Cleanup pixel aliases #7

merged 3 commits into from
Oct 8, 2023

Conversation

bhperry
Copy link
Contributor

@bhperry bhperry commented Oct 7, 2023

Remove pixel package alias leftover from an intermediate name change. With the final naming scheme that we settled on it is not needed.

@bhperry bhperry requested a review from duysqubix October 7, 2023 22:27
@bhperry
Copy link
Contributor Author

bhperry commented Oct 7, 2023

also noticed that we're still referencing github.com/faiface/mainthread and github.com/faiface/glhf, are we ready to switch those over?

@duysqubix
Copy link
Contributor

Not yet. Let me cut a release and I'll update this pr when it's good to go.to not delay this pr. Let's move ahead with this pr. Create another one with changing the aliases for mainthread and glhf and we can merge when the two other projects are ready.

@duysqubix
Copy link
Contributor

Approved

@duysqubix duysqubix merged commit 46ea36f into dev Oct 8, 2023
@bhperry bhperry deleted the remove-alias branch October 8, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants