Implement --batch and --exclude options for opcache:compile:scripts command #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordalina
reviewed
Dec 2, 2019
gordalina
requested changes
Dec 2, 2019
There was a problem hiding this comment.
Thanks for you contribution!
Can you add a test in https://github.com/gordalina/cachetool/blob/master/tests/Proxy/OpcacheProxyTest.php ?
|
@gordalina Done! |
gordalina
approved these changes
Dec 5, 2019
|
Fantastic, thank you for the contribution. |
|
Added in version 5.0.0. Check the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option
--batchallows to compile all files at once (in single php file). It could help warming up opcache on servers withpm.max_requestssetting (when project has big amount of files, php-fpm stops responding after compilingpm.max_requests- 1 files).Option
--excludeallows to exclude paths, opcache for which we don't want to compile. For example we don't want to compile opcache forvendor/directory.