Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Symfony 5.3 & lock php minimum version #183

Merged
merged 4 commits into from
Jun 4, 2021

Conversation

gordalina
Copy link
Owner

Closes #180

@Seldaek
Copy link

Seldaek commented May 30, 2021

Hey @gordalina long time no see ;)

Just a comment here it'd be probably safer to set "composer config platform.php 7.3.0” or whatever minimum php version is supported, that'll ensure composer update doesn't update packages to versions that don't support it, and would not require pinning the package here.

@gordalina
Copy link
Owner Author

Hey @Seldaek, it's been a while 👋!

Thank you for the heads up - this is definitely the right way to do it. Unfortunately, psr/container depends on 7.2 so even with the platform config it requires pinning the package.
Symfony 5.3 was just released and addresses the issue.

@gordalina gordalina changed the title Lock psr/container to 1.0.0 Update to Symfony 5.3 & lock php minimum version Jun 1, 2021
@gordalina gordalina merged commit ae1c72b into master Jun 4, 2021
@gordalina gordalina deleted the sg/cachetool-v6.4 branch June 4, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error on PHP8
2 participants