[Rec-IM] participant matches #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amos-cha
commented
Jun 5, 2024
EjPlatzer
requested changes
Jun 5, 2024
Co-authored-by: Evan Platzer <evan.platzer@gmail.com>
amos-cha
commented
Jun 5, 2024
EjPlatzer
requested changes
Jun 5, 2024
Comment on lines
139
to
141
| .Include(mt => mt.Match) | ||
| .ThenInclude(m => m.MatchTeam) | ||
| .ThenInclude(mt => mt.Match) |
There was a problem hiding this comment.
Is this not a circular include? Aren't you including MatchTeam.Match.MatchTeam.Match?
There was a problem hiding this comment.
Not EXACTLY, the reason I need any of these includes is because of the implicit operators on the viewmodels. Unless specified, they do not actually hold any of their perceived connections.
The logic flow unfortunately right now is as follows:
MatchTeam(1) is connected via a participant's current team list,
I then get the Match from that MatchTeam(1)
I then need ALL MatchTeam(1->x) connected to the Match
The implicit operator is used on the MatchTeam(1->x) which actually loses its connection to Match and thus loses its properties.
So yes, it's "circular" but not really?
…rdon-cs/gordon-360-api into s24-recim-participant-matches
EjPlatzer
requested changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API route for displaying a participant's matches (future and past). Handles the API side of https://github.com/gordon-cs/RecIM-Docs/issues/104