-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S24 banners to club posters UI #2363
Draft
CollyWills16670
wants to merge
20
commits into
develop
Choose a base branch
from
s24-banners-to-club-posters-ui
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/gordon-360-ui into s24-banners-to-club-posters-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state Posters are able to be uploaded (button on top right of Poster home page) with expiration dates and display times working and displayed on the Carousel (Swiper) by club leaders on the 360 home page. The code for priority uploaders is in place as well, which will give admins control to make certain things appear first in the carousel (StudentLife, CEC, Athletics etc.)
Posters are not able to be clicked to show information (times,descriptions) yet, posters are not able to be edited by uploaders and the admin controls for blocking uploaders/removing posters are not finished. Posters are not being displayed on the Involvements profile page based on the club they were uploaded by (there are posters currently displayed there running from dummy data and images).