Add an example to play an mp3 #18
Conversation
examples/mp3.go
Outdated
|
|
||
| portaudio.Initialize() | ||
| defer portaudio.Terminate() | ||
| out := make([]int32, 8192) |
There was a problem hiding this comment.
Here you effectively assume that encoding is mpg123.ENC_SIGNED_32. You should either assert that, make it so, or handle different encodings.
There was a problem hiding this comment.
Good point, will fix in the next update.
| chk(stream.Start()) | ||
| defer stream.Stop() | ||
| for { | ||
| audio := make([]byte, 2*len(out)) |
There was a problem hiding this comment.
2*len(out) is half as many bytes as are necessary to fill out. I'd expect you to hear some pretty bad audio artifacts as a result of the the latter half of out containing silence.
|
|
||
| // create mpg123 decoder instance | ||
| decoder, err := mpg123.NewDecoder("") | ||
| chk(err) |
There was a problem hiding this comment.
chk is not defined. I get the feeling you didn't run this code 😢
There was a problem hiding this comment.
I didn't run this exact code no. That's not possible because main() is defined in all files in the examples dir 😏
But I should indeed have double checked this example by copying the code to a different dir and test it. Will do that and update in a bit...
There was a problem hiding this comment.
Hehe, yeah the easy way is just to do go run mp3.go.
There was a problem hiding this comment.
That's a good one! Thanks for the pointer/suggestion.
|
@gordonklaus just updated the example and double checked it by running this exact code as a standalone program... |
Tried to keep the style inline with the other examples
Fixes #16