Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not allow templates in id fields #3098

Closed
3 tasks done
caarlos0 opened this issue May 11, 2022 · 2 comments
Closed
3 tasks done

do not allow templates in id fields #3098

caarlos0 opened this issue May 11, 2022 · 2 comments
Assignees
@caarlos0
Labels
bug Something isn't working
Milestone
v1.11.0

Comments

@caarlos0
Copy link
Member

What happened?

if we use templates in the id fields, hell might break loose in several different places.

ideally we should block it.

How can we reproduce this?

goreleaser version

all

GoReleaser Check

  • goreleaser check shows no errors

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response
@caarlos0 caarlos0 added bug Something isn't working triage Issue pending triage by one of the maintainers labels May 11, 2022
@caarlos0 caarlos0 self-assigned this May 11, 2022
@caarlos0 caarlos0 removed the triage Issue pending triage by one of the maintainers label May 11, 2022
caarlos0 added a commit that referenced this issue May 11, 2022
@caarlos0
fix: revert defaulting build.id to build.binary
17e4d62 
refs #3098
refs #3063

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0
Copy link
Member Author

just reviewed, there are no more cases of IDs being templated, the last one was fixed in 17e4d62

@caarlos0 caarlos0 added this to the 1.11.0 milestone Aug 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.11.0
Development

No branches or pull requests
1 participant
@caarlos0