Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpm): with defaults: fix version and pre-release #101

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 5, 2019

refs goreleaser/goreleaser#1229 (comment)

not sure this is the right way to go, I'm sleepy and will check again tomorrow :)

fixed in a more proper way, moved the version parse to WithDefaults.

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@@ -146,13 +156,6 @@ func TestWithRPMTags(t *testing.T) {
assert.Equal(t, info.Description, description)
}

func TestRPMVersionWithDash(t *testing.T) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test used to check this because rpmbuild failed if version had a - on it...

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 changed the title fix(rpm): replace - with _ on version fix(rpm): with defaults: fix version and pre-release Nov 5, 2019
@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #101 into master will decrease coverage by 0.32%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #101      +/-   ##
=========================================
- Coverage   71.93%   71.6%   -0.33%     
=========================================
  Files           5       5              
  Lines         481     479       -2     
=========================================
- Hits          346     343       -3     
- Misses         84      85       +1     
  Partials       51      51
Impacted Files Coverage Δ
cmd/nfpm/main.go 0% <0%> (ø) ⬆️
nfpm.go 90.32% <100%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dea0ce...f303dd7. Read the comment docs.

@caarlos0 caarlos0 merged commit 92cd25d into master Nov 5, 2019
@caarlos0 caarlos0 deleted the version branch November 5, 2019 12:38
@caarlos0
Copy link
Member Author

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@goreleaser goreleaser locked as resolved and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants