Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: version release/prerelease options #111

Merged
merged 7 commits into from
Feb 18, 2020

Conversation

astorath
Copy link
Contributor

@astorath astorath commented Dec 5, 2019

problem to solve:

changes:

  • added prerelease option to specify it separately from release
  • for deb: prerelease comes after tilde, release after dash (breaking!)
  • for rpm: prerelease comes with default 0.1 release, release is not changed
  • semver parsing now treats numeric prerelease data as release version
  • semver parsing now treats non-numeric prerelease data as prerelease version

Тужилин Андрей Михайлович and others added 2 commits December 5, 2019 14:05
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR

suggesting couple of changes

nfpm.go Outdated Show resolved Hide resolved
nfpm.go Outdated Show resolved Hide resolved
rpm/rpm.go Outdated Show resolved Hide resolved
rpm/rpm.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   70.94%   70.94%           
=======================================
  Files           6        6           
  Lines         499      499           
=======================================
  Hits          354      354           
  Misses         91       91           
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d13f2d...1bd3789. Read the comment docs.

@caarlos0 caarlos0 merged commit 4c6511a into goreleaser:master Feb 18, 2020
@caarlos0
Copy link
Member

thanks, sorry for the delay

@idryzhov idryzhov mentioned this pull request Mar 11, 2020
@caarlos0
Copy link
Member

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@goreleaser goreleaser locked as resolved and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants