fix(#130): Don't propagate semver metadata into deb metadata.

[erikgeiser]

This pull request closes #130 by not propagating the semver metadata info the Deb.Metadata field. As described in the corresponding issue, this is the expected behaviour for deb files.

EDIT: changed it to wip because I actually don't even know why Deb.Metadata exists if it shouldn't be included in the version.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/m1iekkfas
✅ Preview: https://nfpm-git-fork-erikgeiser-fix-deb-metadata.goreleaser.vercel.app

[erikgeiser]

@caarlos0 is there still a point in keeping Deb.Metadata around at all if it shouldn't be included in the version?

[caarlos0]

I think the user can still set something on nfpm.yaml 🤔

[erikgeiser]

Yes but it won't end up anywhere as far as I can see. Until now in this PR I only removed the part here the metadata is populated automatically, but according to the arguments in the issue it should not end up in the packages version information at all, even if set explicitly in the config. In this case we could just remove the entire Deb.Metadata field altogether.

EDIT: It seems to me that while semver supports metadata, the deb format does not.

[caarlos0]

Yes but it won't end up anywhere as far as I can see. Until now in this PR I only removed the part here the metadata is populated automatically, but according to the arguments in the issue it should not end up in the packages version information at all, even if set explicitly in the config. In this case we could just remove the entire Deb.Metadata field altogether.

I think removing the auto-metadata seems legit, but if the user wants to do add something manually I don't see a problem...

[erikgeiser]

That's a valid argument. However, the counter argument would be that this enables users to create deb packages where the version comparison is broken.

[caarlos0]

That's a valid argument. However, the counter argument would be that this enables users to create deb packages where the version comparison is broken.

It depends:

root@7f2aaf25ce50:/# dpkg --compare-versions 0.1.11~beta3+git eq 0.1.11~beta3+git && echo yes
yes
root@7f2aaf25ce50:/# dpkg --compare-versions 0.1.11~beta4+git gt 0.1.11~beta3+git && echo yes
yes
root@7f2aaf25ce50:/# dpkg --compare-versions 0.1.12~beta3+git gt 0.1.11~beta3+git && echo yes
yes

if the user wants to always set the metadata to git, for example, it works just fine.

The problem is that we were always changing it (setting the commit hash), and them the comparison was broken...

[caarlos0]

Maybe we can just point that out in docs (to not abuse the metadata risking breaking dpkg version comparison)

[erikgeiser]

Okay, let's do it this way. I changed the docs and removed the wip.

[caarlos0]

Thanks!

[caarlos0]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.