Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for deb templates #240

Merged
merged 3 commits into from
Nov 3, 2020
Merged

Conversation

vandot
Copy link

@vandot vandot commented Nov 2, 2020

Add support for templates file inside DEBIAN that is needed for debconf to be able to ask question user during installation. More on subject here and here

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 2, 2020
@vercel
Copy link

vercel bot commented Nov 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/hgavie8cj
✅ Preview: https://nfpm-git-master.goreleaser.vercel.app

@vercel vercel bot temporarily deployed to Preview November 2, 2020 18:20 Inactive
@vandot vandot changed the title add support for deb templates feat: add support for deb templates Nov 2, 2020
@djgilcrease
Copy link
Contributor

Is there a reason this cannot just be handled with the normal files process?

@vandot
Copy link
Author

vandot commented Nov 2, 2020

@djgilcrease templates file needs to be inside DEBIAN folder, maybe I missed something but with files and conffiles files can be only placed in relative installation path outside DEBIAN folder

deb/deb.go Outdated Show resolved Hide resolved
nfpm.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview November 2, 2020 20:38 Inactive
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #240 into master will increase coverage by 0.52%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   66.33%   66.86%   +0.52%     
==========================================
  Files           9        9              
  Lines        1007     1023      +16     
==========================================
+ Hits          668      684      +16     
  Misses        204      204              
  Partials      135      135              
Impacted Files Coverage Δ
nfpm.go 78.04% <ø> (ø)
deb/deb.go 68.56% <96.15%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e2c284...60561b3. Read the comment docs.

Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add it to the docs too?

other than that LGTM

@vercel vercel bot temporarily deployed to Preview November 3, 2020 12:43 Inactive
@vandot
Copy link
Author

vandot commented Nov 3, 2020

Done, added to the docs.

@caarlos0 caarlos0 merged commit 7a70791 into goreleaser:master Nov 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants