Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow using an env var in the signature.key_file field #282

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

djgilcrease
Copy link
Contributor

I want to use the same config file for local builds that are not signed and pipeline builds that are signed so I need to be able to specify the key_file as an env var.

@vercel
Copy link

vercel bot commented Jan 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/h44xi4bpv
✅ Preview: https://nfpm-git-allow-keyfile-env-var.goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 14, 2021
@vercel vercel bot temporarily deployed to Preview January 14, 2021 18:07 Inactive
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #282 (a68a03d) into master (e16b06a) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   69.86%   70.00%   +0.13%     
==========================================
  Files           9        9              
  Lines        1085     1090       +5     
==========================================
+ Hits          758      763       +5     
  Misses        203      203              
  Partials      124      124              
Impacted Files Coverage Δ
nfpm.go 86.00% <100.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16b06a...a68a03d. Read the comment docs.

@djgilcrease djgilcrease merged commit a8e3399 into master Jan 14, 2021
@djgilcrease djgilcrease deleted the allow-key_file-env-var branch January 14, 2021 18:32
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants