-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a keep_version flag #283
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/goreleaser/nfpm/H9Y8y9ttWN79rpwaa6kB3vyqErzM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after a rebase
hey, thanks for the pr and sorry for the delay to review, lost it in the notifications I think... I would say to do something more like:
so its hopefully clearer. wdyt? also need to mention the new option in the docs... |
I like this, then I would change the check to a switch to make it easier to add additional version schema in the future. switch info.VersionSchema {
case "none":
// No change to the version or prerelease info set in the YAML file
break
case "semver":
fallthrough
default:
info.parseSemver()
} |
yep :) |
For me it also looks good. |
change the system to allow multiple version schema parsing systems, currently only `semver` and `none`
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
- Coverage 69.37% 69.18% -0.19%
==========================================
Files 9 9
Lines 1159 1178 +19
==========================================
+ Hits 804 815 +11
- Misses 223 229 +6
- Partials 132 134 +2
Continue to review full report at Codecov.
|
…ersion string is parsed. closes #283
Superceeded by #324 |
…ersion string is parsed. closes #283
…ersion string is parsed. closes #283
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I'm using nfpm for some of my projects. As I already started other projects that also produce packages with a slightly different versioning schema (using other tools) I would like to have a chance to keep my version completely unchanged from the config to the created package.
To be fully compatible I introduced a flag to switch off the semver handling.
As I encountered problems when afterwards building a docker image I added a staticbuild task to the Makefile.
Working image at https://hub.docker.com/repository/docker/wellenvogel/nfpm: wellenvogel/nfpm:1.0