Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependency tree #615

Merged
merged 1 commit into from
Feb 5, 2023
Merged

fix: dependency tree #615

merged 1 commit into from
Feb 5, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Feb 5, 2023

unfortunately, we need to lock go-crypto to that particular version in order to avoid breaking signing in some centos/rhel versions.

make it super clear in the go.mod file to avoid future mistakes, hopefully.

we need to find a good future plan for it though, even if it is specifically not supporting some rpm versions - if I understood it correctly, its actually a bug on a specific rpm version.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug Something isn't working label Feb 5, 2023
@caarlos0 caarlos0 self-assigned this Feb 5, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2023
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #615 (5862201) into main (c17fccc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #615   +/-   ##
=======================================
  Coverage   70.48%   70.48%           
=======================================
  Files          21       21           
  Lines        3168     3168           
=======================================
  Hits         2233     2233           
  Misses        717      717           
  Partials      218      218           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 added the dependencies Pull requests that update a dependency file label Feb 5, 2023
@caarlos0 caarlos0 merged commit b55113f into main Feb 5, 2023
@caarlos0 caarlos0 deleted the deps branch February 5, 2023 14:47
@github-actions github-actions bot added this to the v2.26.0 milestone Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant